Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EW-1053 Add and use Test Factories For TSP #5369

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

MajedAlaitwniCap
Copy link
Contributor

@MajedAlaitwniCap MajedAlaitwniCap commented Dec 2, 2024

Description

to reduce duplicate Code add test factories for:

  1. ExternalClassDto
  2. ExternalUserDto
  3. OauthDataDto
  4. ProvisioningDto
  5. ProvisioningSystemDto
  6. Robj-export-schule
  7. Robj-export-klasse
  8. Robj-export-lehrer-migration
  9. Robj-export-schueler-migration
  10. Robj-export-lehrer
  11. Robj-export-schueler

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/EW-1053

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@@ -0,0 +1,11 @@
import { ExternalClassDto } from '@modules/provisioning';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a linter warning here. If the factory is moved to the module where the corresponding class is located, this should not occur. As an example, you can take the school module, in which there is a 'testing' folder with the corresponding factories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants